code review request: 7115744: Do not call File::deleteOnExit in security tests
Weijun Wang
weijun.wang at oracle.com
Sat Nov 26 14:38:35 UTC 2011
Hi Xuelei
Please take a review:
http://cr.openjdk.java.net/~weijun/7115744/webrev.00/
Most are krb5 tests, one for SSL.
Thanks
Max
Begin forwarded message:
> *Change Request ID*: 7115744
> *Synopsis*: Do not call File::deleteOnExit in security tests
>
>
> === *Description* ============================================================
> File::deleteOnExit (for a temp file in the working directory) is not a good idea;
>
> 1. It's useless in agentvm/savevm mode because the file won't be deleted when the test finishes.
>
> 2. It's not necessary because jtreg will clean up the working directory for you.
>
> 3. If the test fails, maybe you want to keep the file for diagnosis. jtreg can retain it for you.
More information about the security-dev
mailing list