code review request: 7115744: Do not call File::deleteOnExit in security tests

Xuelei Fan xuelei.fan at oracle.com
Sat Nov 26 14:48:59 UTC 2011


Looks fine to me.

As you did not update the copyright years, I think you will only push
the changes to JDK 8. It's OK to me in case you don't want putback to
JDK 7. Otherwise, I would suggest you update the copyright years.

Xuelei

On 11/26/2011 10:38 PM, Weijun Wang wrote:
> Hi Xuelei
> 
> Please take a review:
> 
>    http://cr.openjdk.java.net/~weijun/7115744/webrev.00/
> 
> Most are krb5 tests, one for SSL.
> 
> Thanks
> Max
> 
> 
> Begin forwarded message:
> 
>> *Change Request ID*: 7115744
>> *Synopsis*: Do not call File::deleteOnExit in security tests
>>
>>
>> === *Description* ============================================================
>> File::deleteOnExit (for a temp file in the working directory) is not a good idea;
>>
>> 1. It's useless in agentvm/savevm mode because the file won't be deleted when the test finishes.
>>
>> 2. It's not necessary because jtreg will clean up the working directory for you.
>>
>> 3. If the test fails, maybe you want to keep the file for diagnosis. jtreg can retain it for you.
> 




More information about the security-dev mailing list