hg: jdk8/tl/jdk: 7091369: DatagramSocket/Limit.java failing on 8 and 7u2

[Rémi Forax]

On 09/19/2011 04:21 PM, michael.x.mcmahon at oracle.com wrote:
> Changeset: e3d78fe803d4
> Author:    michaelm
> Date:      2011-09-19 15:14 +0100
> URL:       http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e3d78fe803d4
>
> 7091369: DatagramSocket/Limit.java failing on 8 and 7u2
> Reviewed-by: chegar, alanb
>
> ! src/windows/classes/java/net/TwoStacksPlainDatagramSocketImpl.java
>

Hi Michael,
I'm not a big fan of this code.
I don't see why you're using the precise-rethrow feature here.

I think the code should be:

try {
   super.create();
} catch (SocketException e) {
    fd1 = null;
    throw e;
}

Rémi

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/security-dev/attachments/20110920/2c6e6952/attachment.htm>