code review rquest: 7094842: jaas/auth test/javax/security/auth/Subject/{Synch.java, Synch2.java, Synch3.java} loop forever in agentvm mode

Alan Bateman Alan.Bateman at oracle.com
Sun Sep 25 23:55:18 PDT 2011


Weijun Wang wrote:
> Hi Alan
>
> How did you notice the problem?
The fans on the machine where I was running the tests were at maximum 
speed so I guessed we had a looping thread. I then used jstack to look 
at the thread dumps of each of the agent VMs, one was running Synch, the 
other Synch3 even though those tests had apparently passed.

>
> Webrev at
>
>    http://cr.openjdk.java.net/~weijun/7094842/webrev.00
>
> Here I change the threads to non-daemon, so that if there is anything 
> wrong, there will be a timeout (which sounds better than bringing all 
> tests slow).
>
> Although Synch2 is in othervm mode, I change the style also.
Looks good to me, thanks for jumping on it.

-Alan



More information about the security-dev mailing list