Code Review Request: Generalise com.oracle.security.ucrypto tests

Andrew Hughes ahughes at redhat.com
Thu Mar 29 07:43:21 PDT 2012


Hi all,

As discussed in:

http://mail.openjdk.java.net/pipermail/security-dev/2012-March/004615.html

this webrev:

http://cr.openjdk.java.net/~andrew/enc_tests/webrev.01/

updates the tests as follows:

1.  Tests all available providers, not just ucrypto which is unavailable on OpenJDK.
2.  No longer fails the whole test due to a single failure, but provides a cumulative result instead.
3.  All output goes to System.err so that stack traces correspond to other output for debugging.

The tests pass on all providers, with the exception of PKCS11 which has issues on AES that we're still looking onto.
There were issues with Digest too, but this should be resolved by the fix described in
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6414899

changeset:   4908:cdc128128044
parent:      4888:0194fe5ca404
user:        valeriep
date:        Thu Jan 05 18:18:04 2012 -0800
summary:     6414899: P11Digest  should support cloning

Does this look ok?  If so, can I have a bug ID to commit it and which tree should it go to?

Thanks,
-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: 248BDC07 (https://keys.indymedia.org/)
Fingerprint = EC5A 1F5E C0AD 1D15 8F1F  8F91 3B96 A578 248B DC07




More information about the security-dev mailing list