Code Review Request for 6996769: support AEAD ciphers

[Weijun Wang]

Hi Valerie

Test4512704.java:

    Why not test AES/CBC/PKCS5Padding anymore?

TestKATForGCM.java:

    Is there a URL for the test data?

GaloisCounterMode, GCTR, and GHASH are good.

Thanks
Max



On 11/06/2012 04:48 PM, Weijun Wang wrote:
> CipherCore.java:
>
> 79       * update() must buffer this many bytes before before starting
>
> Dup "before".
>
> 380      AlgorithmParameters getParameters(String algName)
>
> The updated code does not return null anymore. Is there some other
> reason out of this patch? The init() method below seems to support null
> for all modes.
>
> 580                  } else if (key.getAlgorithm().equals("RC2")) {
>
> This seems a bug fix. Is there a regression test for it?
>
> 643, 765  arraycopy
>
> Maybe you can just call Arrays.copyOf()
>
>
> GCMParameters.java:
>
> 70 +        this.tLen = gps.getTLen()/8;
>
> Ar you going to check if getTLen() % 8 == 0?
>
> I haven't read GaloisCounterMode, GSTR and GHASH yet. Guess I'll have to
> study the NIST spec to go on.
>
> Thanks
> Max
>
> On 11/03/2012 07:54 AM, Valerie (Yu-Ching) Peng wrote:
>> Brad or Max,
>>
>> Can either of you review my changes for the following RFE?
>> 6996769: support AEAD ciphers
>>
>> This is the JCE part of changes for the EFP "Support AEAD CipherSuites".
>>
>> The webrev is at:
>> http://cr.openjdk.java.net/~valeriep/6996769/webrev.00/
>>
>> I included IBM copyright in files where some code are adopted from their
>> sample impl.
>>
>> Thanks,
>> Valerie