7194449: String resources for Key Tool and Policy Tool should be in their respective packages

Stephen Flores stephen.flores at oracle.com
Mon Oct 1 19:40:10 PDT 2012


Max,

Yes, I ran the tools and the unit tests which did find missing resources 
that I duplicated. This is not a type of new split, at one time all 3 
tools had there resources in the sun...util.Resources class and the 
JarSigner was split out to not be in the rt.jar, but in tools.jar, so 
this logical conclusion to the spilt.

Steve.

On 09/21/2012 03:45 AM, Weijun Wang wrote:
> Looks fine. I'm only not sure if dividing sun.security.util.Resources
> into 3 files is safe. Is it possible that a string is shared by them? I
> noticed you keep a duplicate of "NEWLINE". Hopefully you already figured
> out all cases.
>
> Thanks
> Max
>
>
> On 09/21/2012 09:49 AM, Stephen Flores wrote:
>> Max, Sean, Alan,
>>
>> Please review this webrev:
>>
>> http://cr.openjdk.java.net/~sflores/7194449/webrev-0/
>>
>> Note: I will respond to any comments when I get back from vacation on
>> Monday Oct. 1.
>>
>> Changes:
>>
>> Moved jarsigner and keytool into their own packages as was done
>> for policytool. Unit tests and release.gmk were updated.
>>
>> Static methods in keytool called by jarsigner were moved to
>> sun.security.tools.KeyStoreUtil.
>>
>> Spit out the String resources for keytool and policytool from
>> sun.security.util.Resources into their respective packages.
>>
>> Sean,
>>
>> If everything is OK, can you commit the changes?
>>
>> Thanks,
>>
>> Steve.
>>



More information about the security-dev mailing list