7194449: String resources for Key Tool and Policy Tool should be in their respective packages

Stephen Flores stephen.flores at oracle.com
Mon Oct 1 19:41:50 PDT 2012


Max,

I got the impression from Alan that we will only do that when asked.

Steve.

On 09/21/2012 03:48 AM, Weijun Wang wrote:
> Also, I remember we agreed on leaving a s.s.t.KeyTool class whose main()
> simply calls s.s.t.k.Main.main(). Are we still going to do that?
>
> Thanks
> Max
>
> On 09/21/2012 03:45 PM, Weijun Wang wrote:
>> Looks fine. I'm only not sure if dividing sun.security.util.Resources
>> into 3 files is safe. Is it possible that a string is shared by them? I
>> noticed you keep a duplicate of "NEWLINE". Hopefully you already figured
>> out all cases.
>>
>> Thanks
>> Max
>>
>>
>> On 09/21/2012 09:49 AM, Stephen Flores wrote:
>>> Max, Sean, Alan,
>>>
>>> Please review this webrev:
>>>
>>> http://cr.openjdk.java.net/~sflores/7194449/webrev-0/
>>>
>>> Note: I will respond to any comments when I get back from vacation on
>>> Monday Oct. 1.
>>>
>>> Changes:
>>>
>>> Moved jarsigner and keytool into their own packages as was done
>>> for policytool. Unit tests and release.gmk were updated.
>>>
>>> Static methods in keytool called by jarsigner were moved to
>>> sun.security.tools.KeyStoreUtil.
>>>
>>> Spit out the String resources for keytool and policytool from
>>> sun.security.util.Resources into their respective packages.
>>>
>>> Sean,
>>>
>>> If everything is OK, can you commit the changes?
>>>
>>> Thanks,
>>>
>>> Steve.
>>>



More information about the security-dev mailing list