JDK8 Code review request for 7199939 and 7199941

Vincent Ryan vincent.x.ryan at oracle.com
Mon Sep 24 02:39:16 PDT 2012

Fixes look good.
Just a minor comment at l.150 of ParameterCache: the test could use '<='??

On 22 Sep 2012, at 00:45, Valerie (Yu-Ching) Peng wrote:

> Hi, Vinnie,
> Can you please review these following 2 JDK8 fixes? They are straight forward regressions found by SQE tests introduced as byproducts of the NSA Suite B changes.
> Since they are already caught by existing SQE tests, so I didn't add more regression tests.
> 7199939: DSA 576 ad 640 bit keys fail when initializing for No precomputed parameters
> Webrev: http://cr.openjdk.java.net/~valeriep/7199939/webrev.00/
> Fix: Fixed the impl of DSAKeyPairGenerator.initialize(int, SecureRandom) so it will attempt to generate new parameters (instead 
> of error out) when no precomputed parameters are available. Also fixed ParameterCache.getNewDSAParameterSpec(...) method to handle legacy DSA key sizes.
> 7199941: test about AES/ECB mode fails
> Webrev: http://cr.openjdk.java.net/~valeriep/7199941/webrev.00/
> Fix: Moved the initialization of the field 'blockMode' back to the right code block.
> The failed SQE tests now pass after the code changes.
> Thanks!
> Valerie

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/security-dev/attachments/20120924/88c2613b/attachment.html 

More information about the security-dev mailing list