[JDK-9] RFR: 8050370: Need new regressions tests for messageDigest with DigestIOStream

[zaiyao liu]

Hi Max,

Thanks for review.

testDigestOnOff including following two cases.

  * Test digest when set digest function on:
      o Set the digest function on both DigestInputStream and
        DigestOutputStream
      o Perform the update for using all available/possible update
        methods, update action including call read()  read data from
        DigestInputStream then write data to DigestOutputStream.
      o Compare generated digest values of DigestInputStream and
        DigestOutputStream
  * Test digest when turns digest function on and off:
      o Turns the digest function on and off, set same digest function
        value for DigestInputStream and DigestOutputStream in one update
        cycle.
      o Perform the update for using all available/possible update methods
      o Compare generated digest values of DigestInputStream and
        DigestOutputStream

Please review the comments, if OK I will update this comments into webrev.

Thanks again.

Kevin
于 2014/8/18 16:43, Wang Weijun 写道:
> Hi Kevin
>
> I tried to read the new test. TestMDChange and TestMDShare are OK, but I am confused on what testDigestOnOff is doing. Can you add some comments there?
>
> Thanks
> Max
>
> On Aug 18, 2014, at 14:35, zaiyao liu <zaiyao.liu at oracle.com> wrote:
>
>> Hi Brad,
>>
>> Can you help to review this new test for DigestIOStream?
>>
>> Thanks
>>
>> Kevin
>> 于 2014/8/1 11:10, zaiyao liu 写道:
>>> May I request you to review 1 new test to be added for messageDigest with DigestIOStream. New test are added to address following:
>>> - Test DigestInputStream and DigestOutputStream digest function when digest set on and off
>>> - Test DigestInputStream and DigestOutputStream digest function when Swap the message digest engines between DigestIn/OutputStream
>>> - Test DigestInputStream and DigestOutputStream digest function when use same message digest object.
>>>   
>>>
>>> JDK Issue: https://bugs.openjdk.java.net/browse/JDK-8050370
>>> Webrev: http://cr.openjdk.java.net/~rhalade/8050370/webrev.00/
>>>
>>> Thanks,
>>>      
>>> Kevin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/security-dev/attachments/20140819/549dac4c/attachment.htm>