RFR 8033271: Manual security tests have @ignore rather than @run main/manual
Rajan Halade
rajan.halade at oracle.com
Sat Mar 15 00:52:23 UTC 2014
Thanks Xuelei for your comment. I updated all tests as per your suggestion -
http://cr.openjdk.java.net/~wetmore/8033271/webrev.02/
Please review again.
Thanks,
Rajan
On 3/14/2014 16:39, Xuelei Fan wrote:
> I like the changes. I'm afraid the lines following the @summary tag will
> be joined into one line during testing. We had such bad experiences in
> a lot JSSE tests. Would you like put the manual testing comment into a
> separated commend block?
>
> For example, change the update
>
> * @summary Ensure authentication via GSS-API/Kerberos v5 works.
> - * @ignore see runwjaas.csh for instructions for how to run this test
> - */
> -/*
> - * Can set logging to FINEST to view exchange.
> + * Set logging to FINEST to view exchange.
> + * See runwjaas.csh for instructions for how to run this test
> + *
> + * @run main/manual AuthOnly
>
> To
>
> * @summary Ensure authentication via GSS-API/Kerberos v5 works.
> - * @ignore see runwjaas.csh for instructions for how to run this test
> + * @run main/manual AuthOnly
> */
>
> /*
> - * Can set logging to FINEST to view exchange.
> + * Set logging to FINEST to view exchange.
> + * See runwjaas.csh for instructions for how to run this test
> */
>
> Thanks,
> Xuelei
>
> On 3/15/2014 4:07 AM, Rajan Halade wrote:
>> Please review this fix:
>>
>> http://cr.openjdk.java.net/~wetmore/8033271/webrev.01/
>>
>> I removed @ignore from all these tests and marked them with manual for
>> now. These tests will be considered for automation as a separate effort
>> and will be executed manually for now.
>>
>> Thanks,
>> Rajan
>>
More information about the security-dev
mailing list