Code review request [JDK 9] 8042449 Issue for negative byte major record version

[Xuelei Fan]

On 5/6/2014 9:31 PM, Florian Weimer wrote:
> On 05/06/2014 02:00 PM, Xuelei Fan wrote:
> 
>> Storing both int version and major/minor byte versions is a little bit
>> redundancy.  The update is significant.  I will focus on the signed byte
>> issue in this fix.
> 
> Yes, I get that.  I've verified that you've covered all the version
> comparisons.
> 
Thanks for the code review.  Do you have a OpenJDK author account?

> I was just wondering if accessor methods (or storing the values as ints)
> would make it less likely that the issue reoccurs in a different
> variant.
I think, it should be better.

Thanks,
Xuelei

> But the new checkRecordVersion() probably covers that.
>