RFR: 8073108: GHASH Intrinsics

Anthony Scarpino anthony.scarpino at oracle.com
Fri Feb 20 20:58:31 UTC 2015


On 02/19/2015 05:36 PM, Vladimir Kozlov wrote:
> JDK changes review.
> -------------------
> All exceptions should print invalid value as you did for state and
> subkeyH checks. It would greatly help debugging.
>
> Please, split first check into 3 separate checks and print invalid value
> to know which condition failed.
>
> Missing space after 'length': "invalid length"+subkeyH.length

webrev updated:
http://cr.openjdk.java.net/~ascarpino/8073108/jdk/webrev.02/

Tony



More information about the security-dev mailing list