RFR: 8073108: GHASH Intrinsics

Vladimir Kozlov vladimir.kozlov at oracle.com
Sat Feb 21 01:42:47 UTC 2015


Perfect. No more comments from me.

Thanks,
Vladimir

On 2/20/15 12:58 PM, Anthony Scarpino wrote:
> On 02/19/2015 05:36 PM, Vladimir Kozlov wrote:
>> JDK changes review.
>> -------------------
>> All exceptions should print invalid value as you did for state and
>> subkeyH checks. It would greatly help debugging.
>>
>> Please, split first check into 3 separate checks and print invalid value
>> to know which condition failed.
>>
>> Missing space after 'length': "invalid length"+subkeyH.length
>
> webrev updated:
> http://cr.openjdk.java.net/~ascarpino/8073108/jdk/webrev.02/
>
> Tony
>


More information about the security-dev mailing list