RFR 8058849: test/sun/security/krb5/config/dns.sh needs to re-examined or replaced

Alan Bateman Alan.Bateman at oracle.com
Mon Jun 29 08:02:51 UTC 2015


On 29/06/2015 08:55, Weijun Wang wrote:
> Please review the fix at
>
>    http://cr.openjdk.java.net/~weijun/8058849/webrev.00
>
> The overridden NamingManager needs to return a Context object whose 
> getAttributes() method returns hard coded data. Since Context includes 
> a lot of interface methods, choosing a non-abstract child and only 
> overriding its getAttributes() method will make the code much shorter. 
> Before the fix, com.sun.jndi.dns.DnsContext is chosen but 
> unfortunately it does not belong to java.naming module anymore. We now 
> choose InitialDirContext instead.
So it's not that the DNS provider is in own module, it is that it no 
longer defined to the boot loader.

In any case, the change looks okay to me. Trivially, I think I would use 
specific imports rather than changing it a wildcard.

-Alan.



More information about the security-dev mailing list