RFR: JDK-6996366 : convert MacAlg to an enum

Xuelei Fan xuelei.fan at oracle.com
Sat Mar 14 08:08:34 UTC 2015


Looks fine to me.

Do you want to consider a similar conversion on BulkCipher?  Maybe in a
new bug.

Thanks,
Xuelei

On 3/12/2015 7:55 AM, Jamil Nimeh wrote:
> Hello all,
> 
> This bug moves the internal MacAlg concrete class to an enum, and alters
> the CipherSuite constructor to no longer use String parsing on the
> cipher suite name to determine the MacAlg.  Instead, the constructor now
> requires the caller to pass in a MacAlg, similar to how it already takes
> a KeyExchange and BulkCipher.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-6996366
> Webrev: http://cr.openjdk.java.net/~jnimeh/reviews/6996366/webrev.01/
> 
> Thanks,
> --Jamil




More information about the security-dev mailing list