RFR: JDK-6996366 : convert MacAlg to an enum

Jamil Nimeh jamil.j.nimeh at oracle.com
Sat Mar 14 10:54:52 UTC 2015


Or we could just take care of it now, since I'm already making enums out 
of things.

http://cr.openjdk.java.net/~jnimeh/reviews/6996366/webrev.02/

I don't see any differences in jtreg results across the 211 ssl tests I 
ran so that seems like a good sign.  I've got a jprt run going now to 
see if anything happens there.  Let me know what you think.

--Jamil

On 03/14/2015 01:08 AM, Xuelei Fan wrote:
> Looks fine to me.
>
> Do you want to consider a similar conversion on BulkCipher?  Maybe in a
> new bug.
>
> Thanks,
> Xuelei
>
> On 3/12/2015 7:55 AM, Jamil Nimeh wrote:
>> Hello all,
>>
>> This bug moves the internal MacAlg concrete class to an enum, and alters
>> the CipherSuite constructor to no longer use String parsing on the
>> cipher suite name to determine the MacAlg.  Instead, the constructor now
>> requires the caller to pass in a MacAlg, similar to how it already takes
>> a KeyExchange and BulkCipher.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-6996366
>> Webrev: http://cr.openjdk.java.net/~jnimeh/reviews/6996366/webrev.01/
>>
>> Thanks,
>> --Jamil



More information about the security-dev mailing list