[9] RFR: 7145757: CertificateExtensions uses non-consistent key names

Wang Weijun weijun.wang at oracle.com
Fri Mar 27 10:53:52 UTC 2015


> On Mar 27, 2015, at 06:37, Jason Uh <jason.uh at oracle.com> wrote:
> 
> Please review this revision:
> http://cr.openjdk.java.net/~juh/7145757/01/
> 
> * a global nameCache is maintained in OIDMap as suggested

Can you just use the existing OIDMap.getId() method? It looks like your getCachedOid(name) is the same as getId("x509.info.extensions." + name).

In fact, since the OIDMap only contains mapping of extensions, I'd suggest renaming it to ExtensionMap and change the name inside to short names (without the "x509.info.extensions." prefix).

--Max



More information about the security-dev mailing list