[9] RFR: 7145757: CertificateExtensions uses non-consistent key names

[Wang Weijun]

> On Mar 28, 2015, at 05:19, Jason Uh <jason.uh at oracle.com> wrote:
> 
> 
> 
> On 03/27/2015 03:53 AM, Wang Weijun wrote:
>> 
>>> On Mar 27, 2015, at 06:37, Jason Uh <jason.uh at oracle.com> wrote:
>>> 
>>> Please review this revision:
>>> http://cr.openjdk.java.net/~juh/7145757/01/
>>> 
>>> * a global nameCache is maintained in OIDMap as suggested
>> 
>> Can you just use the existing OIDMap.getId() method? It looks like your getCachedOid(name) is the same as getId("x509.info.extensions." + name).
>> 
>> In fact, since the OIDMap only contains mapping of extensions, I'd suggest renaming it to ExtensionMap and change the name inside to short names (without the "x509.info.extensions." prefix).
> 
> OK, thanks for that suggestion. I thought there was some significance to using the "full" name in OIDMap,

I think it was designed to be more powerful (see how OtherName uses it) but unfortunately it hasn't been so. Now that with jdk9/module it is no more accessible from outside the JDK, we can simplify it.

> but if that's not necessary, it makes things more flexible. Here is the latest revision that uses only the existing OIDMap (now called ExtensionsMap).
> 
> http://cr.openjdk.java.net/~juh/7145757/02/

Will read it.

Thanks
Max

> 
> Thanks,
> Jason
> 
>> --Max
>>