RFR 8048357: PKCS basic tests

[Weijun Wang]

Hi Amanda

On 11/17/2015 15:03, Amanda Jiang wrote:
> http://cr.openjdk.java.net/~amjiang/8048357/webrev.03/
>
>> Why "othervm" for all these tests?

The pkcs10 and pkcs8 tests still uses othervm. Is that necessary? I see 
no VM static change made by these tests.

>> PKCS8Test.java:
>>
>> - sun.security.x509 in @modules?
> This test uses "sun.misc.HexDumpEncoder", so that's why security.x509 is
> in @modules.

I was asking about sun.security.x509, not sun.misc.

>>
>> pkcs7/*.java:
>>
>> Please take a look at Bernd Eckenfels's comments on Aug 21. I fully agree with him.

In PKCS7VerifyTest.java, you are still using is.available() to get the 
size of FILEPATH + args[1].

In SignerOrder.java, can you explain what the contents of derString1 and 
derString2 means? You seem to be choosing some specially crafted 
DER-encoded bytes but I don't know the reason. The names and the 
contents just keep me guessing what they are.

Everything else is fine.

Thanks
Max