RFR 8139436: sun.security.mscapi.KeyStore might load incomplete data

[Langer, Christoph]

Hi,



please review a change proposal regarding an issue in the Microsoft Security API (mscapi).



Bug: https://bugs.openjdk.java.net/browse/JDK-8139436

Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8139436.0/



I stumbled over the issue when using an old IAIK security provider. It would throw java.security.cert.CertificateException upon parsing ECC based certificates when generating Certificate objects. The way it is right now, such exceptions are silently caught and the Windows Keystore is created with incomplete data. Upon accessing such ECC certificates from the Keystore object, e.g. when iterating over it, you'll get exceptions like:

Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: 0

        at sun.security.mscapi.KeyStore.engineGetCertificate(KeyStore.java:313)

        at sun.security.mscapi.KeyStore$ROOT.engineGetCertificate(KeyStore.java:60)

        at java.security.KeyStore.getCertificate(KeyStore.java:1095)

At that point it is not obvious what the real root cause for that is.



With my change, loading of the keystore would already throw like this:

java.io.IOException: java.security.KeyStoreException: Exception occurred generating certificate object for alias DigiCert Assured ID Root G3

        at sun.security.mscapi.KeyStore.engineLoad(KeyStore.java:780)

        at sun.security.mscapi.KeyStore$ROOT.engineLoad(KeyStore.java:60)

        at java.security.KeyStore.load(KeyStore.java:1459)

        at WindowsCertificateReaderTest.main(WindowsCertificateReaderTest.java:18)

Caused by: java.security.KeyStoreException: Exception occurred generating certificate object for alias DigiCert Assured ID Root G3

        at sun.security.mscapi.KeyStore.loadKeysOrCertificateChains(Native Method)

        at sun.security.mscapi.KeyStore.engineLoad(KeyStore.java:777)

        ... 3 more

Caused by: java.security.cert.CertificateException: Error parsing certificates! iaik.asn1.DerInputException: Next ASN.1 object is no OBJECT IDENTIFIER!

        at iaik.x509.CertificateFactory.engineGenerateCertificates(Unknown Source)

        at java.security.cert.CertificateFactory.generateCertificates(CertificateFactory.java:462)

        at sun.security.mscapi.KeyStore.generateCertificate(KeyStore.java:869)

        ... 5 more

This is more obvious when it comes to analyzing such an issue.



Also, I added a property "sun.security.mscapi.ignoreFailingCertificates" which, when set to true, will cause skipping of certificates that failed with Exception. That might be a nice workaround option if one is not particularly interested in a failing certificate.



You can reproduce all this with the test coding in the OpenJDK Bug, the IAIK provider 3.15 which is downloadable here: http://jcewww.iaik.tu-graz.ac.at/sic/Download (educational/research version, needs registration) and ECC certificates in the Windows Root certificate store.



Would you think this change is reasonable and worthwile?



Thanks & Best regards

Christoph

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/security-dev/attachments/20151012/66adae39/attachment.htm>