RFR 8136425: KeystoreImpl.m using wrong type for cert format

Wang Weijun weijun.wang at oracle.com
Sat Sep 12 09:23:45 UTC 2015


Please take a look at

   http://cr.openjdk.java.net/~weijun/8136425/webrev.00/ <http://cr.openjdk.java.net/~weijun/8136425/webrev.00/>

It looks like a wrong type is used, kSecFormatX509Cert and kSecFormatWrappedPKCS8 are of SecExternalFormat and the SecKeychainItemImport function also uses this type for its 3rd argument. Constants and function are all defined in

   http://www.opensource.apple.com/source/libsecurity_keychain/libsecurity_keychain-40768/lib/SecImportExport.h <http://www.opensource.apple.com/source/libsecurity_keychain/libsecurity_keychain-40768/lib/SecImportExport.h>

It is an enum, so still works.

Thanks
Max

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/security-dev/attachments/20150912/5d5c9555/attachment.htm>


More information about the security-dev mailing list