RFR 8136425: KeystoreImpl.m using wrong type for cert format

Vincent Ryan vincent.x.ryan at oracle.com
Sat Sep 12 12:55:53 UTC 2015


Your fix looks fine to me.
Thanks.


> On 12 Sep 2015, at 10:23, Wang Weijun <weijun.wang at oracle.com> wrote:
> 
> Please take a look at
> 
>    http://cr.openjdk.java.net/~weijun/8136425/webrev.00/ <http://cr.openjdk.java.net/~weijun/8136425/webrev.00/>
> 
> It looks like a wrong type is used, kSecFormatX509Cert and kSecFormatWrappedPKCS8 are of SecExternalFormat and the SecKeychainItemImport function also uses this type for its 3rd argument. Constants and function are all defined in
> 
>    http://www.opensource.apple.com/source/libsecurity_keychain/libsecurity_keychain-40768/lib/SecImportExport.h <http://www.opensource.apple.com/source/libsecurity_keychain/libsecurity_keychain-40768/lib/SecImportExport.h>
> 
> It is an enum, so still works.
> 
> Thanks
> Max
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/security-dev/attachments/20150912/4140b0ea/attachment-0001.html>


More information about the security-dev mailing list