RFR 8056174: New APIs for jar signing

Sean Mullan sean.mullan at oracle.com
Mon Sep 28 19:27:21 UTC 2015


Looks good, just a couple of comments:

AlgorithmId: can you use braces around the conditional statements on 
lines 1008-1017?

Function: are you missing an @modules tag for the jarsigner module?

Options.java: why not use the JarSigner API here instead of the 
jarsigner tool?

--Sean

On 09/21/2015 11:43 PM, Weijun Wang wrote:
> Missing from the webrev, some extra lines needed in modules.xml of the
> parent repo jdk9/dev:
>
>     <module>
>       <name>jdk.jartool</name>
>       <depend>java.base</depend>
>       <export>
>         <name>com.sun.jarsigner</name>
>       </export>
> +    <export>
> +      <name>jdk.security.jarsigner</name>
> +    </export>
>     </module>
>
> Thanks
> Max
>
> On 09/22/2015 09:12 AM, Weijun Wang wrote:
>> OK, webrev updated at
>>
>>    http://cr.openjdk.java.net/~weijun/8056174/webrev.05/
>>
>> A new method setProperty() is added to JarSigner.Builder (as well as
>> getProperty() in JarSigner) to cover all misc settings. JarSignerX and
>> BuilderX are removed now.
>>
>> Thanks
>> Max
>>


More information about the security-dev mailing list