RFR 8056174: New APIs for jar signing

[Weijun Wang]

On 9/29/2015 3:27 AM, Sean Mullan wrote:
> Looks good, just a couple of comments:
>
> AlgorithmId: can you use braces around the conditional statements on
> lines 1008-1017?

OK.

>
> Function: are you missing an @modules tag for the jarsigner module?

Which one? I thought @modules is only used if you want to call 
non-exported classes.

>
> Options.java: why not use the JarSigner API here instead of the
> jarsigner tool?

This test is to make sure jarsigner still behaves correctly after it is 
modified to be based on the JarSigner API. As for the API itself, I use 
Function.java to check its function and Spec.java to check it's spec.

I'll add some @summary.

Thanks
Max

>
> --Sean
>
> >    http://cr.openjdk.java.net/~weijun/8056174/webrev.05/
>>