Code Review Request JDK-8146387, Test SSLSession/SessionCacheSizeTests socket accept timed out

Wang Weijun weijun.wang at oracle.com
Mon Jan 11 08:10:58 UTC 2016


Can you make sure every read to serverPorts is after serverReady = true? I hope so but cannot confirm it, especially in the constructor (on line 342 etc). Or shouldn't you always start the server at port 0 and then read it into serverPorts? You want to start a server on the same port on and on?

Thanks
Max

> On Jan 9, 2016, at 7:06 PM, Xuelei Fan <xuelei.fan at oracle.com> wrote:
> 
> Hi,
> 
> Please review a test update for JDK-8146387:
> 
>   http://cr.openjdk.java.net/~xuelei/8146387/webrev.00/
> 
> In the test case, javax/net/ssl/SSLSession/SessionCacheSizeTests.java,
> an integer (createdPorts) is used to count the server sockets.  Every
> server socket is created in a new thread.  The access and update to
> createdPorts should be synchronized for multiple threading safe.
> 
> Thanks,
> Xuelei



More information about the security-dev mailing list