Code Review Request JDK-8146387, Test SSLSession/SessionCacheSizeTests socket accept timed out
Bradford Wetmore
bradford.wetmore at oracle.com
Tue Jan 12 01:01:34 UTC 2016
272: I would suggest using MAX_ACTIVE_CONNECTIONS to initialize this
array, in case there is ever a resizing done in the future.
I see we are doing timeout tests elsewhere in the test suite, good.
Looks ok otherwise.
Brad
On 1/10/2016 8:10 PM, Xuelei Fan wrote:
> Hi Weijun,
>
> Are you available review this test fix?
>
> Updated to use try-with-resources for server socket. Keep the client
> socket closure unchanged in order to keep this fix simple and easy to
> verify.
>
> http://cr.openjdk.java.net/~xuelei/8146387/webrev.01/
>
> Thanks,
> Xuelei
>
>
> On 1/9/2016 7:06 PM, Xuelei Fan wrote:
>> Hi,
>>
>> Please review a test update for JDK-8146387:
>>
>> http://cr.openjdk.java.net/~xuelei/8146387/webrev.00/
>>
>> In the test case, javax/net/ssl/SSLSession/SessionCacheSizeTests.java,
>> an integer (createdPorts) is used to count the server sockets. Every
>> server socket is created in a new thread. The access and update to
>> createdPorts should be synchronized for multiple threading safe.
>>
>> Thanks,
>> Xuelei
>>
>
More information about the security-dev
mailing list