RFR 8158589: Possible integer overflow issues for DRBG

Wang Weijun weijun.wang at oracle.com
Tue Jun 7 03:52:18 UTC 2016


Hi All

Please take a review at

   http://cr.openjdk.java.net/~weijun/8158589/webrev.00/

For the reseedCounter case, the default reseedInterval is Integer.MAX_VALUE and there is no integer bigger than it, therefore a new check reseedCounter < 0 is added. I had thought about making it long but can a long field be a safe volatile? I am not sure.

I added a label noreg-cleanup, or maybe noreg-hard is better?

Thanks
Max




More information about the security-dev mailing list