RFR 6968542: keytool -importcert cannot deal with duplicate certs
Wang Weijun
weijun.wang at oracle.com
Thu Jun 16 13:47:15 UTC 2016
> On Jun 16, 2016, at 5:17 PM, Xuelei Fan <xuelei.fan at oracle.com> wrote:
>
> Maybe better to throw an exception so that the caller know that the
> reply is not valid. Tolerate problems may become a problem in the future.
In this case, I only remove duplicated certs. Nothing else is tolerated.
>
> If you want to tolerate the duplicate cert in the chain, please add a
> comment about the use of hash set. The purpose of the use of hash set
> is not instinctive to the code reader.
Sure.
So does this mean you've approved my code changes?
Thanks
Max
>
> Xuelei
>
> On 6/16/2016 4:53 PM, Wang Weijun wrote:
>> Please review the code change at
>>
>> http://cr.openjdk.java.net/~weijun/6968542/webrev.01/
>>
>> Thanks
>> Max
>>
>
More information about the security-dev
mailing list