RFR 8027781: New jarsigner timestamp warning is grammatically incorrect

[Sean Mullan]

On 06/16/2016 12:17 AM, Wang Weijun wrote:
> Hi Sean
>
> Please review a resource string change
>
> diff --git a/src/jdk.jartool/share/classes/sun/security/tools/jarsigner/Resources.java b/src/jdk.jartool/share/classes/sun/security/tools/jarsigner/Resources.java
> --- a/src/jdk.jartool/share/classes/sun/security/tools/jarsigner/Resources.java
> +++ b/src/jdk.jartool/share/classes/sun/security/tools/jarsigner/Resources.java
> @@ -255,7 +255,7 @@
>           {"no.timestamp.signing",
>                   "No -tsa or -tsacert is provided and this jar is not timestamped. Without a timestamp, users may not be able to validate this jar after the signer certificate's expiration date (%1$tY-%1$tm-%1$td)."},
>           {"no.timestamp.verifying",
> -                "This jar contains signatures that does not include a timestamp. Without a timestamp, users may not be able to validate this jar after the signer certificate's expiration date (%1$tY-%1$tm-%1$td)."},
> +                "This jar contains signatures that do not include a timestamp. Without a timestamp, users may not be able to validate this jar after any of the signer certificates expires (as early as %1$tY-%1$tm-%1$td)."},
>           {"Unknown.password.type.", "Unknown password type: "},
>           {"Cannot.find.environment.variable.",
>                   "Cannot find environment variable: "},
>
> I haven't used "one or more signatures" because many other jarsigner warnings use "This jar contains entries..." which do not have the words.
>
> About the expiration date, the warning is already showing the earliest one, so I added "as early as".
>
> Please note that when signing, the warning always shows the expiration date of the signer, even if there are other existing signatures without a timestamp.

Looks good, one nit on the wording:

"... after any of the signer certificates expires ..."

s/expires/expire/

>
> I assume this is a bug fix and no CCC is needed. Right?

Right.

--Sean