RFR: 8157561 :Ship the unlimited policy files in JDK Updates

Bradford Wetmore bradford.wetmore at oracle.com
Mon Nov 7 18:53:46 UTC 2016


Great, thanks.  Looks good.

Brad



On 11/7/2016 3:34 AM, Seán Coffey wrote:
> Thanks for review Brad. I've included an extra check in CryptoLevel to
> check for "limited/unlimited" input. Addressed the JceSecurity
> indentation issue also.
>
> http://cr.openjdk.java.net/~coffeys/webrev.8157561.8u.jdk.v5/webrev/
>
> Regards,
> Sean.
>
> On 04/11/16 22:56, Bradford Wetmore wrote:
>> I didn't see anything majorly different in what I looked at earlier, I
>> didn't check java.security or the test case.
>>
>>
>> CryptoLevel.java
>> ================
>> 49: Your usage mentions only unlimited|limited.  Do you want to
>> include a check for that?
>>
>> JceSecurity.java
>> ================
>> 300:  Indention problem.
>>
>> Looks ok otherwise.
>>
>> Thanks,
>>
>> Brad
>>
>>
>>
>>
>> On 11/4/2016 7:16 AM, Erik Joelsson wrote:
>>> Build changes look ok to me.
>>>
>>> /Erik
>>>
>>>
>>> On 2016-11-04 14:42, Seán Coffey wrote:
>>>> Looking to push this enhancement to jdk8u. The change introduces the
>>>> new Security property which was brought into JDK 9 via JDK-8061842.
>>>>
>>>> The code differs in that jar files continue to be used and backwards
>>>> compatibility is maintained. If the new security property is not
>>>> defined and the policy jar files exist in the legacy locations, then
>>>> those jar files will continue to be honoured.
>>>>
>>>> https://bugs.openjdk.java.net/browse/JDK-8157561
>>>> webrev :
>>>> http://cr.openjdk.java.net/~coffeys/webrev.8157561.8u.jdk.v4/webrev/
>>>>
>>>
>



More information about the security-dev mailing list