RFR[9] JDK-8077138: Some PKCS11 tests fail because NSS library is not initialized

Vincent Ryan vincent.x.ryan at oracle.com
Tue Sep 13 10:16:43 UTC 2016


The code changes look fine (but your webrev shows zero lines changed throughout).


> On 13 Sep 2016, at 10:43, John Jiang <sha.jiang at oracle.com> wrote:
> 
> Hi,
> Please review this patch for fixing JDK-8077138.
> The solution is re-building NSS libraries with VS2013, and then the new NSS DLLs can depend on msvcr120.dll, which is already distributed with JDK 9.
> 
> And please note that, this patch also removes the PKCS11 tests from ProblemList.txt, though these tests have another issue JDK-8023434.
> JDK-8023434 is related to Solaris, but the PKCS11 tests are marked with windows-all. So, I think it's no meaning to keep such items. Then, these tests will really be executed on Windows platforms.
> 
> Webrev: http://cr.openjdk.java.net/~jjiang/8077138/webrev.00/
> Issue: https://bugs.openjdk.java.net/browse/JDK-8077138
> 
> Best regards,
> John Jiang
> 



More information about the security-dev mailing list