RFR[9] JDK-8077138: Some PKCS11 tests fail because NSS library is not initialized

[Weijun Wang]

Hi John

I just noticed this webrev request.

After syncing with jdk9/dev, the PKCS11 tests still fail on my 64-bit 
Windows 10 machine. I had always thought [1] the failure is due to the 
DLLs without the executable bit. In fact, after I chmod a+x them, the 
tests pass.

How did you confirm your change works? Did the test fail with the old 
DLLs on your test machine and succeed with the new ones?

Thanks
Max

[1] 
https://bugs.openjdk.java.net/browse/JDK-8023434?focusedCommentId=13860118&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13860118

On 9/13/2016 17:43, John Jiang wrote:
> Hi,
> Please review this patch for fixing JDK-8077138.
> The solution is re-building NSS libraries with VS2013, and then the new
> NSS DLLs can depend on msvcr120.dll, which is already distributed with
> JDK 9.
>
> And please note that, this patch also removes the PKCS11 tests from
> ProblemList.txt, though these tests have another issue JDK-8023434.
> JDK-8023434 is related to Solaris, but the PKCS11 tests are marked with
> windows-all. So, I think it's no meaning to keep such items. Then, these
> tests will really be executed on Windows platforms.
>
> Webrev: http://cr.openjdk.java.net/~jjiang/8077138/webrev.00/
> Issue: https://bugs.openjdk.java.net/browse/JDK-8077138
>
> Best regards,
> John Jiang
>