[9] RFR: 8164591: sun/net/www/protocol/https/HttpsClient/ServerIdentityTest.java failed with SSLHandshakeException

[Xuelei Fan]

As you were already there, I would suggest to consider the 
SSLSocketSample.java template as the comment in JDK-8163924 review thread.

Thanks,
Xuelei

On 9/15/2016 9:13 AM, Artem Smotrakov wrote:
> Not urgent, but I would appreciate if someone can get a chance to look
> at this.
>
> Artem
>
>
> On 09/07/2016 03:17 PM, Artem Smotrakov wrote:
>> Sending to net-dev at openjdk.java.net as well.
>>
>> Artem
>>
>>
>> On 09/07/2016 12:28 PM, Artem Smotrakov wrote:
>>> Hello,
>>>
>>> Please review the following patch for
>>> sun/net/www/protocol/https/HttpsClient/ServerIdentityTest.java
>>>
>>> The test has been observed to fail a couple of times, but it's still
>>> not clear why it failed because there is not much info in logs. The
>>> patch updates the test to enable additional debug output, so that we
>>> have more info if it fails next time.
>>>
>>> While looking at the test, I notices a couple of issues, but they
>>> don't seem to cause these intermittent failures:
>>> - The test sets system properties for JSSE in a loop, but JSSE
>>> provider reads them only once while initialization. As a result, only
>>> values which were set in the first iteration are actually used.
>>> - The test doesn't close files and sockets sometimes.
>>>
>>> The patch also fixed the issues above, and there are a couple
>>> cosmetic changes.
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8164591
>>> Webrev: http://cr.openjdk.java.net/~asmotrak/8164591/webrev.00/
>>>
>>> Artem
>>
>