[9] RFR: 8156054: Test Task: Develop new tests for JEP C155: Remove FilePermission Pathname Canonicalization

Sibabrata Sahoo sibabrata.sahoo at oracle.com
Thu Sep 15 06:39:46 UTC 2016


Hi Artem,

 

I think building a String value from the actual result and displaying it against expected in the Log output will be more convenient here. 

 

Thanks,

Siba

 

From: Artem Smotrakov 
Sent: Tuesday, September 13, 2016 10:54 PM
To: Sibabrata Sahoo; Weijun Wang; security-dev at openjdk.java.net
Subject: Re: [9] RFR: 8156054: Test Task: Develop new tests for JEP C155: Remove FilePermission Pathname Canonicalization

 

Hi Siba,

I see that the test expects only true or false. You can just pass these boolean values, and check() can make sure that everything returns the expected boolean value without building a string. That would be clearer to me. Not an issue, it's up to you to change it or not.

Artem

 

On 09/13/2016 03:14 AM, Sibabrata Sahoo wrote:

Hi,

 

Please review the patch for,

 

JBS: https://bugs.openjdk.java.net/browse/JDK-8156054

Webrev: HYPERLINK "http://cr.openjdk.java.net/%7Essahoo/8156054/webrev.00/"http://cr.openjdk.java.net/~ssahoo/8156054/webrev.00/

 

Description: 

It checks equals(), implies() and hashCode () of FilePermission when "jdk.io.permissionsUseCanonicalPath" set and un-set. Along with, it also verify compatibility with previous JDK version.

 

 

Thanks,

Siba

 

 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/security-dev/attachments/20160914/3331558a/attachment.html>


More information about the security-dev mailing list