RFR 8172975: SecurityTools.keytool() needs to accept user input

Artem Smotrakov artem.smotrakov at oracle.com
Fri Jan 20 11:23:58 UTC 2017


It's up to you. You can change it now if you have time, or we can do it 
once we need to update jarsigner tests.

Artem


On 01/20/2017 12:23 PM, Weijun Wang wrote:
>>> Also, I am feeling that the jarsigner-related calls are quite
>>> complicated. I suggest we use the same method for signing and
>>> verifying and ask the user to provide all arguments in their order. So
>>> instead of calling
>>>
>>>    SecurityTools.jarsigner("x.jar", "alias", "...");
>>>
>>> we just call
>>>
>>>    SecurityTools.jarsigner("... x.jar alias");
>> This looks better to me as well.
>>
>> I am fine with current webrevs.
>
> A little confused. Do you think the current webrev is fine or is it 
> better to rewrite jarsigner()? 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/security-dev/attachments/20170120/16afef65/attachment.html>


More information about the security-dev mailing list