RFR JDK-8164639: Configure PKCS11 tests to use user-supplied NSS libraries

[Weijun Wang]

Can test.nss.lib.path contain multiple paths? For example, some systems might have libsoftkn3.so and libnss3.so in different directories [1] and depending on whether secmod is used the test might load one or the other. I have the same question on the downloaded file from the artifact server. It seems for each platform it is a zip file. Will it extract all libraries into the same "nsslib" directory?

Also, this is the 1st time I hear about @Artifact in an openjdk test and know nothing about it. Is there a detailed description on this feature somewhere? As for this test, if customNssLib is the first element in nssLibDirs and not set by a user, does this mean the test will always download libraries from an artifact server? Would it spend too much time on downloading? Is there a cache mechanism so that after the 1st PKCS11 test downloads the libraries the other tests can reuse them? Are they cleaned up at some time?

Thanks
Max

[1] https://packages.ubuntu.com/xenial-updates/arm64/libnss3/filelist

> On Aug 13, 2018, at 10:44 AM, sha.jiang at oracle.com wrote:
> 
> Hi,
> This patch provides a system property, exactly test.nss.lib.path, for specifying the absolute path to the custom NSS lib.
> And it also removes the NSS 3.16 binary libs on windows and macosx from repo.
> On these two platforms, PKCS11 tests will download new built NSS 3.35 libs from Artifactory.
> 
> Webrev: http://cr.openjdk.java.net/~jjiang/8164639/webrev.00/
> Issue: https://bugs.openjdk.java.net/browse/JDK-8164639
> 
> Best regards,
> John Jiang
>