RFR JDK-8164639: Configure PKCS11 tests to use user-supplied NSS libraries

[sha.jiang at oracle.com]

Thanks for the comments!
Please take a look the updated webrev: 
http://cr.openjdk.java.net/~jjiang/8164639/webrev.02/
Only README was adjusted.

Best regards,
John Jiang

On 2018/8/14 23:48, Rajan Halade wrote:
> Few minor comments on README:
>
> - Please leave an empty line after each numbered section
> - I would suggest to update #2 to have general instruction on use of 
> artifactory. Something like
>
> 2. Pre-built NSS libraries from artifactory server
>     If the value of system property test.nss.lib.paths is null then tests will try
>     to download pre-built NSS libraries from artifactory server.
>     Currently, test only looks for libraries for Windows and MacOSX on artifactory.
>     Please note that, JIB jar MUST be present in classpath when downloading the libraries.
> Other changes look good to me.
>
> Thanks,
> Rajan
>
> On 8/14/18 4:40 AM, sha.jiang at oracle.com wrote:
>>
>> Hi Max,
>> Please review the new webrev: 
>> http://cr.openjdk.java.net/~jjiang/8164639/webrev.01/
>>
>> The new system property has been renamed to test.nss.lib.paths, and 
>> it supports multiple paths.
>> Currently, it cannot download the artifacts outside Oracle network. 
>> This affects the test executions on Windows and MacOSX.
>> I added a block to README for clarifying something on getting NSS 
>> libraries.
>>
>> Best regards,
>> John Jiang
>>
>> On 2018/8/13 16:48, Weijun Wang wrote:
>>> Sorry, more questions:
>>>
>>>> On Aug 13, 2018, at 3:36 PM,sha.jiang at oracle.com  wrote:
>>>>
>>>>> Is there an artifact server available on the open internet?
>>>> It's transparent to me. @Artifact tool delegates the downloading.
>>> Have you tried running the test outside Oracle?
>>>
>>> Have you tried submitting the change to Mach5 as a non-Oracle developer? (i.e. using submit-repo)
>>>
>>> While I am glad to see these files removed from the repo, I hope people still have a chance to run the tests.
>>>
>>> Thanks
>>> Max
>>>
>>>
>>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/security-dev/attachments/20180815/359d9c07/attachment.htm>