RFR 8197518: Kerberos krb5 authentication: AuthList's put method leads to performance issue

Weijun Wang weijun.wang at oracle.com
Sat Feb 24 02:20:51 UTC 2018



> On Feb 24, 2018, at 12:38 AM, Daniel Fuchs <daniel.fuchs at oracle.com> wrote:
> 
> Hi Max,
> 
>  85                 // has larger timestamp.
>  86                 entries.addFirst(t);
> 
> shouldn't you set oldestTime here as well?

The order might be a little misleading, you addFirst() the latest entry and the oldest one is at getLast(). oldestTime is set on line 78 because it's the only entry. But for line 86, there are already existing entries.

--Max

> 
> best regards,
> 
> -- daniel
> 
> On 23/02/2018 15:21, Xuelei Fan wrote:
>> Looks fine to me.
>> Xuelei
>> On 2/23/2018 6:13 AM, Weijun Wang wrote:
>>> Updated at http://cr.openjdk.java.net/~weijun/8197518/webrev.02/.



More information about the security-dev mailing list