RFR 8197518: Kerberos krb5 authentication: AuthList's put method leads to performance issue

Daniel Fuchs daniel.fuchs at oracle.com
Mon Feb 26 10:59:24 UTC 2018


On 24/02/2018 02:20, Weijun Wang wrote:
> The order might be a little misleading, you addFirst() the latest entry and the oldest one is at getLast(). oldestTime is set on line 78 because it's the only entry. But for line 86, there are already existing entries.

Oh, right, that's my mistake!

Thanks Max, and best regards,

-- daniel

On 24/02/2018 02:20, Weijun Wang wrote:
>> On Feb 24, 2018, at 12:38 AM, Daniel Fuchs<daniel.fuchs at oracle.com>  wrote:
>>
>> Hi Max,
>>
>>   85                 // has larger timestamp.
>>   86                 entries.addFirst(t);
>>
>> shouldn't you set oldestTime here as well?
> The order might be a little misleading, you addFirst() the latest entry and the oldest one is at getLast(). oldestTime is set on line 78 because it's the only entry. But for line 86, there are already existing entries.
> 
> --Max
> 



More information about the security-dev mailing list