SSLLogger.java (was Re: Code Review Request: TLS 1.3 Implementation)

[Xuelei Fan]

On 6/6/2018 5:41 AM, Weijun Wang wrote:
> There are lots of calls like
> 
>     RSAClientKeyExchangeMessage ckem =
>             new RSAClientKeyExchangeMessage(shc, message);
>     if (SSLLogger.isOn && SSLLogger.isOn("ssl,handshake")) {
>         SSLLogger.fine(
>             "Consuming RSA ClientKeyExchange handshake message", ckem);
>     }
> 
> which finally calls to
> 
>     String formatted =
>          SSLSimpleFormatter.formatParameters(params);
>     logger.log(level, msg, formatted);
> 
> Now that msg contains no placeholder likes "{0}", nothing on temporary will be shown.
> 
I did not catch you here. SSLSimpleFormatter is a package private class 
(SSLLogger#SSLSimpleFormatter), which does not use placeholder in msg.

Thanks,
Xuelei

> Am I understanding this correctly?
> 
> Thanks
> Max
>