SSLContextImpl.java (was Re: Code Review Request: TLS 1.3 Implementation)

[Weijun Wang]

The protocols (for example, SSLParameters::getProtocols) are now from new to old, which is opposite from the previous order. Why make this change?

  41  * Instances of this class are immutable after the context is initialized.

You mean instances of child of this class? It looks like this class itself can be init() multiple times.

 414         return Arrays.asList(suites.toArray(new CipherSuite[0]));

Is this better than new ArrayList(suites)?

 940                 candidates = new ProtocolVersion[refactored.size()];
 941                 candidates = refactored.toArray(candidates);

Why not candidates = refactored.toArray(new ProtocolVersion[refactored.size()]);

 943             System.out.println(refactored.toString());

Please remove.

Another thing in CipherSuite.java:

  803     static CipherSuite nameOf(String ciperSuiteName) {

Why isn't this method named valueOf()?

No other comment.

Thanks
Max