SSLContextImpl.java (was Re: Code Review Request: TLS 1.3 Implementation)

Weijun Wang weijun.wang at oracle.com
Mon Jun 11 14:36:39 UTC 2018



> On Jun 11, 2018, at 10:32 PM, Xuelei Fan <xuelei.fan at oracle.com> wrote:
> 
>> 
>> Another thing in CipherSuite.java:
>>   803     static CipherSuite nameOf(String ciperSuiteName) {
>> Why isn't this method named valueOf()?
> There is a default builtin valueOf(String) method for enum type.

Ah, I see. But given the return type is a value, maybe simply of()?

nameOf() sounds like it would return a name.

--Max





More information about the security-dev mailing list