Code Review Request, JDK-8214321: Misleading code in SSLCipher
Xue-Lei Fan
xuelei.fan at oracle.com
Tue Nov 27 00:14:12 UTC 2018
Hi,
Please review this code cleanup in SSLCipher.java:
http://cr.openjdk.java.net/~xuelei/8214321/webrev.00/
The code should be fine as readCipherGenerators.length and
writeCipherGenerators.length are the same value in the implementation.
However, it is misleading to use readCipherGenerators when it is
intended to use writeCipherGenerators. It's nice to have a code cleanup
for readability.
Thanks,
Xuelei
More information about the security-dev
mailing list