RFR[12] JDK-8211978: move testlibrary/jdk/testlibrary/SimpleSSLContext.java and testkeys to network testlibrary

[sha.jiang at oracle.com]

Please review the updated webrev:
http://cr.openjdk.java.net/~jjiang/8211978/webrev.01/
AbstractSSLTubeTest.java and FlowTest.java now use the same 
internal.net.http.SimpleSSLContext.java

In addition, it looks the original jdk/testlibrary/SimpleSSLContext.java 
could accept an alternative keystore file,
so I don't change this logic and keep the binary testkeys.

Best regards,
John Jiang

On 2018/10/15 17:55, sha.jiang at oracle.com wrote:
> At least, the inner SimpleSSLContext classes in 
> AbstractSSLTubeTest.java and FlowTest.java could be combined.
> I'm doing it.
>
> Best regards,
> John Jiang
>
> On 2018/10/15 17:21, Daniel Fuchs wrote:
>> Hi Max,
>>
>> These tests are whitebox tests - the tests classes are patched
>> into the java.net.http module, and as a consequence they can't
>> compile against library classes which are on the classpath.
>> This is the unfortunate reason for the presence of a
>> SimpleSSLContext clone in there.
>>
>> best regards,
>>
>> -- daniel
>>
>> On 15/10/2018 03:53, Weijun Wang wrote:
>>> Hi John
>>>
>>> I see testkeys is directly referenced in AbstractSSLTubeTest.java 
>>> and FlowTest.java by an inner class also named SimpleSSLContext. Is 
>>> it very different from the one in SimpleSSLContext.java? Can they be 
>>> combined?
>>>
>>> If so, then we have a chance to ASCII-fy the testkeys file and 
>>> directly include it inside SimpleSSLContext.java. This way we can 
>>> delete one more binary file and do not need to care about file 
>>> permissions. What a marvelous gain would that be!
>>>
>>> Thanks
>>> Max
>>
>>
>
>