RFR 8201355 : Avoid native memory allocation in sun.security.mscapi.PRNG.generateSeed

Weijun Wang weijun.wang at oracle.com
Thu Oct 18 01:01:28 UTC 2018


Looks fine to me.

Thanks
Max

> On Oct 18, 2018, at 2:03 AM, Ivan Gerasimov <ivan.gerasimov at oracle.com> wrote:
> 
> Hello!
> 
> In the function Java_sun_security_mscapi_PRNG_generateSeed() a native memory is allocated, and then its content is copied into a freshly allocated Java array.  The native memory allocation can be avoided, which also makes the code shorter.
> 
> Would you please help review the fix?
> 
> BUGURL: https://bugs.openjdk.java.net/browse/JDK-8201355
> WEBREV: http://cr.openjdk.java.net/~igerasim/8201355/00/webrev/
> 
> -- 
> With kind regards,
> Ivan Gerasimov
> 




More information about the security-dev mailing list