RFR 8212216: JGSS: Fix leak in exception cases in getJavaOID()

Weijun Wang weijun.wang at oracle.com
Tue Oct 23 04:28:19 UTC 2018


Maybe noreg-trivial is for lazy people. I'll remove it and add a comment.

Thanks
Max


> On Oct 22, 2018, at 11:30 PM, Sean Mullan <sean.mullan at oracle.com> wrote:
> 
> Looks fine to me. It is unusual to have two noreg labels on a bug. Is that acceptable? I would probably choose one or the other. noreg-hard seems more appropriate to me.
> 
> --Sean
> 
> On 10/15/18 9:34 PM, Weijun Wang wrote:
>> Please take a review at
>>    http://cr.openjdk.java.net/~weijun/8212216/webrev.00/
>> This bug is reported and fixed by Nico Williams <nico at twosigma.com>.
>> No regression test, memory leak.
>> Thanks
>> Max




More information about the security-dev mailing list