RFR[12] JDK-8209546: Make sun/security/tools/keytool/autotest.sh to support macosx
Weijun Wang
weijun.wang at oracle.com
Tue Sep 25 14:30:47 UTC 2018
Some questions:
1. Do we still need the OS check on lines 47-49? As long as getLibPath() can return something, does it mean the test should just run? Especially, does the test run on Windows?
2. Is launching a separate process necessary? Can we just call KeyToolTest::main after setting system properties and copying the files.
3. Is it possible to include standard.sh?
Thanks
Max
> On Sep 25, 2018, at 6:30 PM, sha.jiang at oracle.com wrote:
>
> Hi,
> JDK-8164639 removed NSS libs from repo, so sun/security/tools/keytool/autotest.sh has to download NSS libs from artifactory on macosx.
> This patch also refactors this shell test to a Java test.
>
> Webrev: http://cr.openjdk.java.net/~jjiang/8209546/webrev.00/
> Issue: https://bugs.openjdk.java.net/browse/JDK-8209546
>
> Best regards,
> John Jiang
>
More information about the security-dev
mailing list