RFR[12] JDK-8209546: Make sun/security/tools/keytool/autotest.sh to support macosx

[sha.jiang at oracle.com]

Hi Max,

On 2018/9/25 22:30, Weijun Wang wrote:
> Some questions:
>
> 1. Do we still need the OS check on lines 47-49? As long as getLibPath() can return something, does it mean the test should just run? Especially, does the test run on Windows?
The original test ignores Windows, and says "This test is only executed 
on several platforms".
So, I didn't change this test logic.
But I'll have a try without that OS checking.
>
> 2. Is launching a separate process necessary? Can we just call KeyToolTest::main after setting system properties and copying the files.
I did think about this point.
It looks this test could be run by manual if someone want to set those 
system properties.
I supposed that's why KeyToolTest.java is not a jtreg test.

>
> 3. Is it possible to include standard.sh?
No problem. This test looks quite similar to autotest.sh.

Best regards,
John Jiang
>
> Thanks
> Max
>
>> On Sep 25, 2018, at 6:30 PM, sha.jiang at oracle.com wrote:
>>
>> Hi,
>> JDK-8164639 removed NSS libs from repo, so sun/security/tools/keytool/autotest.sh has to download NSS libs from artifactory on macosx.
>> This patch also refactors this shell test to a Java test.
>>
>> Webrev: http://cr.openjdk.java.net/~jjiang/8209546/webrev.00/
>> Issue: https://bugs.openjdk.java.net/browse/JDK-8209546
>>
>> Best regards,
>> John Jiang
>>
>