[13] RFR JDK-8183107: PKCS11 regression regarding checkKeySize
Jamil Nimeh
jamil.j.nimeh at oracle.com
Tue Feb 26 16:57:50 UTC 2019
Hi Valerie, looks good, I only had one comment and it's more of a nit
than anything else.
* P11KeyPairGenerator.java
o 122-124: I think those lines could be safely moved under the
algorithm.equals("RSA") clause up at line 113 and get rid of the
extra check at line 121.
--Jamil
On 2/22/19 1:14 PM, Valerie Peng wrote:
>
> Anyone can help reviewing this fix? According to the bug report, some
> vendors return 0 for both min/max key size range when queried which
> leads to unexpected errors when SunPKCS11 provider validates key
> sizes. So, I modified the code to work around this. No new regression
> test as this is vendor specific and not an issue for the current
> PKCS11 libraries used in regression testing.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8183107
>
> Webrev: http://cr.openjdk.java.net/~valeriep/8183107/webrev.00/
>
> Mach5 run is clean.
>
> Thanks,
> Valerie
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/security-dev/attachments/20190226/b8128cd6/attachment.htm>
More information about the security-dev
mailing list